fix: ensure passwords in helm templates are quoted #96
+19
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR should not be merged until validator-labs/validator#342 is merged and a new release of validator is created. We'll need to bump our dependencies to use the latest version of validator. |
Codecov ReportAttention: Patch coverage is @@ Coverage Diff @@
## main #96 +/- ##
==========================================
- Coverage 52.32% 52.28% -0.05%
==========================================
Files 45 45
Lines 5005 5009 +4
==========================================
Hits 2619 2619
- Misses 1725 1729 +4
Partials 661 661
Continue to review full report in Codecov by Sentry.
|
dosubot
bot
added
size:S
ahmad-ibra
changed the title
TylerGillson
approved these changes
Jul 24, 2024
ahmad-ibra
pushed a commit
that referenced
this pull request
Jul 24, 2024
🤖 I have created a release *beep* *boop* --- ## [0.0.5](v0.0.4...v0.0.5) (2024-07-24) ### Features * add support for private custom image registries ([#83](#83)) ([ae91659](ae91659)) * support env vars in OCI secrets ([#88](#88)) ([584b3c7](584b3c7)) ### Bug Fixes * ensure passwords in helm templates are quoted ([#96](#96)) ([f36383b](f36383b)) ### Other * omit EDITOR logs by default ([#76](#76)) ([b3ab7ec](b3ab7ec)) ### Dependency Updates * **deps:** update anchore/sbom-action action to v0.17.0 ([#75](#75)) ([caf800d](caf800d)) * **deps:** update golang.org/x/exp digest to 8a7402a ([#89](#89)) ([3ffda87](3ffda87)) * **deps:** update golang.org/x/exp digest to e3f2596 ([#82](#82)) ([a89beb6](a89beb6)) * **deps:** update module github.com/validator-labs/validator to v0.0.47 ([#92](#92)) ([8c359e1](8c359e1)) * **deps:** update module github.com/validator-labs/validator to v0.0.48 ([#94](#94)) ([743656d](743656d)) * **deps:** update module github.com/validator-labs/validator-plugin-azure to v0.0.13 ([#79](#79)) ([0c2dff7](0c2dff7)) * **deps:** update module github.com/validator-labs/validator-plugin-network to v0.0.18 ([#87](#87)) ([c69e355](c69e355)) * **deps:** update module github.com/validator-labs/validator-plugin-network to v0.0.19 ([#95](#95)) ([e70433a](e70433a)) * **deps:** update module github.com/validator-labs/validator-plugin-oci to v0.0.11 ([#90](#90)) ([a633962](a633962)) * **deps:** update module github.com/validator-labs/validator-plugin-vsphere to v0.0.27 ([#80](#80)) ([feb6360](feb6360)) * **deps:** update module github.com/vmware/govmomi to v0.39.0 ([#93](#93)) ([2a01e95](2a01e95)) * **deps:** update softprops/action-gh-release digest to c062e08 ([#85](#85)) ([b8b5c62](b8b5c62)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is to address issues like the one below when converting yaml to json:
The other changes made in the components package to the
ConfigureXXXPluginfunctions ensure they each setup their structs correctly to avoid nil pointer dereferences